[Mlir-commits] [mlir] [mlir][tosa] Add accumulator verifier for FP8 types for AvgPool2D (PR #134727)

Georgios Pinitas llvmlistbot at llvm.org
Mon Apr 7 14:04:55 PDT 2025


================
@@ -600,6 +600,11 @@ LogicalResult tosa::AvgPool2dOp::verify() {
   if (inputETy.isF32() && !accType.isF32())
     return emitOpError("accumulator type for f32 tensor is not f32");
 
+  if ((llvm::isa<Float8E5M2Type>(inputETy) ||
----------------
GeorgeARM wrote:

Should we move the checks in the validation pass? Maybe we can leave the operator verifier a bit more relaxed ie just check that the accumulator is of fp type?
Thoughts?
Cc: @lhutton1 @FranklandJack

https://github.com/llvm/llvm-project/pull/134727


More information about the Mlir-commits mailing list