[Mlir-commits] [mlir] [MLIR][LLVM] Block address support (PR #134335)
Tobias Gysi
llvmlistbot at llvm.org
Sat Apr 5 05:33:31 PDT 2025
================
@@ -726,8 +726,9 @@ struct LLVMInlinerInterface : public DialectInlinerInterface {
}
bool isLegalToInline(Operation *op, Region *, bool, IRMapping &) const final {
- // The inliner cannot handle variadic function arguments.
- return !isa<LLVM::VaStartOp>(op);
+ // The inliner cannot handle variadic function arguments nor blocktag
+ // operations.
----------------
gysit wrote:
```suggestion
// The inliner cannot handle variadic function arguments and blocktag operations prevent inlining since they
// the blockaddress operations reference them via the callee symbol.
```
nit: tried to clarify a bit what the semantics of the blocktag operation is.
https://github.com/llvm/llvm-project/pull/134335
More information about the Mlir-commits
mailing list