[Mlir-commits] [mlir] [MLIR][SCF] Add support for vectorization hints in `scf-to-cf` lowering. (PR #134201)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

I share the concern from @mgehre-amd. We have scf-to-cf lowering precisely because we don't want scf to lower directly to LLVM. There are other targets than LLVM IR.

Furthermore, this indiscriminately adds a hint to _disable_ the vectorizer. I'm not sure this is always desirable. This rather sounds like an optimization decision that should be taken and implemented by a separate pass, independent of lowering.

https://github.com/llvm/llvm-project/pull/134201