[Mlir-commits] [mlir] [mlir][bufferization] Add tensor-like and memref-like interfaces (PR #134220)

[Oleksandr Alex Zinenko]

ftynse wrote:

I'll leave it up to @matthias-springer , but I find it weird to attach interfaces in dialect initialization of another, irrelevant dialect. We already have external models for bufferization op interfaces, e.g., https://github.com/llvm/llvm-project/blob/e4f76e3a3335dda608c661d76efacc70e607a5e4/mlir/lib/Dialect/Vector/Transforms/BufferizableOpInterfaceImpl.cpp#L318. I'd expect we do the same for bufferization type interfaces. AFAICS, `one-shot-bufferize` does not list the bufferization dialect as dependent, so there is no guarantee it is loaded when the pass runs. I'd find it worryingly inconsistent if built-in types wouldn't bufferize when another dialect is not loaded.

https://github.com/llvm/llvm-project/pull/134220