[Mlir-commits] [mlir] [mlir][llvm] Add `LLVM_DependentLibrariesAttr` (PR #133385)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for working on this long awaited feature :)

As you probably have seen it is quite hard to map this in MLIR. Especially since transformations may break some of the invariants:
- We probably have to prevent inlining if a function contains a tag since this would break the reference? I added a comment how todo that.
- The unreachable block case is a bit scary. I assume the only solution there is to fail the import and hope that never shows up? 
- One thing I am unsure about is what happens if MLIR's simplify region merges two blocks that contain two block tags. Then two tags would resolve to the same merged block. I assume that can be exported again and does probably not cause any problems on the MLIR side. However, is this maintaining LLVM semantics? I.e. two block addresses before the import would resolve to a single block address after the export back to LLVM IR?

https://github.com/llvm/llvm-project/pull/133385