[Mlir-commits] [mlir] [MLIR][Linalg] pack, unpack to take memref inputs (PR #129036)

[Han-Chung Wang]

================
@@ -373,6 +376,9 @@ static GenericOp packGenericOp(RewriterBase &rewriter, GenericOp genericOp,
 static FailureOr<GenericOp>
 bubbleUpPackOpThroughGenericOp(RewriterBase &rewriter, linalg::PackOp packOp,
                                const ControlPropagationFn &controlFn) {
+  if (!packOp.hasPureTensorSemantics())
+    return failure();
+
----------------
hanhanW wrote:

I think it is a redundant check, as all the precondition checks happen in `matchAndRewrite` methods. Can you remove it?

https://github.com/llvm/llvm-project/pull/129036