[Mlir-commits] [mlir] [MLIR][Tensor] Remove FoldDimOf[Expand|Collapse]Shape Pattern (PR #134219)

[Quinn Dawkins]

https://github.com/qedawkins requested changes to this pull request.

Agree, dropping the canonicalizers is not the right fix here. The crash is because this comment is outdated: https://github.com/llvm/llvm-project/blob/835a35c31a9a6abd265f05d3d8fb1919fbed781c/mlir/lib/Dialect/Tensor/IR/TensorOps.cpp#L2011-L2012

`expand_shape` takes a list of output sizes now so we can simplify these canonicalizers to just forward the value in `output_shape`

https://github.com/llvm/llvm-project/pull/134219