[Mlir-commits] [mlir] 7d441d9 - [mlir] Use `dyn_cast` instead of `cast` in MathToVCIX conversion (#134047)

[llvmlistbot at llvm.org]

Author: Longsheng Mou
Date: 2025-04-02T18:30:42+08:00
New Revision: 7d441d9892295a6eb8aaf481e1715f039f6f224f

URL: https://github.com/llvm/llvm-project/commit/7d441d9892295a6eb8aaf481e1715f039f6f224f
DIFF: https://github.com/llvm/llvm-project/commit/7d441d9892295a6eb8aaf481e1715f039f6f224f.diff

LOG: [mlir] Use `dyn_cast` instead of `cast` in MathToVCIX conversion (#134047)

Fixes #131093.

Added: 
    

Modified: 
    mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir
    mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir b/mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir
index 3563b2c1cf810..9d4bf7bdb5655 100644
--- a/mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir
+++ b/mlir/test/Conversion/MathToVCIX/math-to-vcix.mlir
@@ -191,3 +191,14 @@ func.func @log_fixed(%a: vector<8 x f32>, %rvl: i64) -> vector<8 x f32> {
   %res = math.log %a : vector<8 x f32>
   return %res : vector<8 x f32>
 }
+
+// -----
+
+// Ensure this case exit gracefully
+
+// CHECK-LABEL:   func.func @no_vector_type
+// CHECK:           math.cos
+func.func @no_vector_type(%arg0: f32) -> f32 {
+  %0 = math.cos %arg0 : f32
+  return %0 : f32
+}

diff  --git a/mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp b/mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp
index 1e45ab57ebcc7..8a01a0af59b22 100644
--- a/mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp
+++ b/mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp
@@ -25,7 +25,7 @@ namespace {
 /// according to LLVM's encoding:
 /// https://lists.llvm.org/pipermail/llvm-dev/2020-October/145850.html
 static std::pair<unsigned, VectorType> legalizeVectorType(const Type &type) {
-  VectorType vt = cast<VectorType>(type);
+  VectorType vt = dyn_cast<VectorType>(type);
   // To simplify test pass, avoid multi-dimensional vectors.
   if (!vt || vt.getRank() != 1)
     return {0, nullptr};