[Mlir-commits] [mlir] [mlir] Remove extraneous calls to make_range (NFC) (PR #134020)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/134020.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Mesh/IR/MeshOps.cpp (+9-25) 


``````````diff
diff --git a/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp b/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
index 65475b69dbdb1..1a1334f0ea474 100644
--- a/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
+++ b/mlir/lib/Dialect/Mesh/IR/MeshOps.cpp
@@ -693,10 +693,7 @@ bool MeshSharding::equalSplitAndPartialAxes(const MeshSharding &rhs) const {
 
   if (getPartialAxes().size() != rhs.getPartialAxes().size() ||
       (!getPartialAxes().empty() && getPartialType() != rhs.getPartialType()) ||
-      !llvm::equal(
-          llvm::make_range(getPartialAxes().begin(), getPartialAxes().end()),
-          llvm::make_range(rhs.getPartialAxes().begin(),
-                           rhs.getPartialAxes().end()))) {
+      !llvm::equal(getPartialAxes(), rhs.getPartialAxes())) {
     return false;
   }
 
@@ -708,11 +705,9 @@ bool MeshSharding::equalSplitAndPartialAxes(const MeshSharding &rhs) const {
     return false;
   }
 
-  return llvm::all_of(llvm::make_range(getSplitAxes().begin() + minSize,
-                                       getSplitAxes().end()),
+  return llvm::all_of(llvm::drop_begin(getSplitAxes(), minSize),
                       std::mem_fn(&MeshAxesAttr::empty)) &&
-         llvm::all_of(llvm::make_range(rhs.getSplitAxes().begin() + minSize,
-                                       rhs.getSplitAxes().end()),
+         llvm::all_of(llvm::drop_begin(rhs.getSplitAxes(), minSize),
                       std::mem_fn(&MeshAxesAttr::empty));
 }
 
@@ -723,19 +718,14 @@ bool MeshSharding::equalHaloAndShardSizes(const MeshSharding &rhs) const {
 bool MeshSharding::equalShardSizes(const MeshSharding &rhs) const {
   if (rhs.getStaticShardedDimsOffsets().size() !=
           getStaticShardedDimsOffsets().size() ||
-      !llvm::equal(llvm::make_range(getStaticShardedDimsOffsets().begin(),
-                                    getStaticShardedDimsOffsets().end()),
-                   llvm::make_range(rhs.getStaticShardedDimsOffsets().begin(),
-                                    rhs.getStaticShardedDimsOffsets().end()))) {
+      !llvm::equal(getStaticShardedDimsOffsets(),
+                   rhs.getStaticShardedDimsOffsets())) {
     return false;
   }
   if (rhs.getDynamicShardedDimsOffsets().size() !=
           getDynamicShardedDimsOffsets().size() ||
-      !llvm::equal(
-          llvm::make_range(getDynamicShardedDimsOffsets().begin(),
-                           getDynamicShardedDimsOffsets().end()),
-          llvm::make_range(rhs.getDynamicShardedDimsOffsets().begin(),
-                           rhs.getDynamicShardedDimsOffsets().end()))) {
+      !llvm::equal(getDynamicShardedDimsOffsets(),
+                   rhs.getDynamicShardedDimsOffsets())) {
     return false;
   }
   return true;
@@ -743,17 +733,11 @@ bool MeshSharding::equalShardSizes(const MeshSharding &rhs) const {
 
 bool MeshSharding::equalHaloSizes(const MeshSharding &rhs) const {
   if (rhs.getStaticHaloSizes().size() != getStaticHaloSizes().size() ||
-      !llvm::equal(llvm::make_range(getStaticHaloSizes().begin(),
-                                    getStaticHaloSizes().end()),
-                   llvm::make_range(rhs.getStaticHaloSizes().begin(),
-                                    rhs.getStaticHaloSizes().end()))) {
+      !llvm::equal(getStaticHaloSizes(), rhs.getStaticHaloSizes())) {
     return false;
   }
   if (rhs.getDynamicHaloSizes().size() != getDynamicHaloSizes().size() ||
-      !llvm::equal(llvm::make_range(getDynamicHaloSizes().begin(),
-                                    getDynamicHaloSizes().end()),
-                   llvm::make_range(rhs.getDynamicHaloSizes().begin(),
-                                    rhs.getDynamicHaloSizes().end()))) {
+      !llvm::equal(getDynamicHaloSizes(), rhs.getDynamicHaloSizes())) {
     return false;
   }
   return true;

``````````

</details>


https://github.com/llvm/llvm-project/pull/134020