[Mlir-commits] [mlir] [mlir][gpu] Add address space modifier to Barrier (PR #110527)

[Krzysztof Drewniak]

krzysz00 wrote:

... I take back some of what I said earlier. On AMDGPU/ROCDL, the lowering of `gpu.barrier` comes down to

```
def ROCDL_BarrierOp : ROCDL_Op<"barrier"> {
  string llvmBuilder = [{
    llvm::LLVMContext &llvmContext = builder.getContext();
    builder.CreateFence(llvm::AtomicOrdering::Release,
                        llvmContext.getOrInsertSyncScopeID("workgroup"));
    createIntrinsicCall(builder, llvm::Intrinsic::amdgcn_s_barrier);
    builder.CreateFence(llvm::AtomicOrdering::Acquire,
                        llvmContext.getOrInsertSyncScopeID("workgroup"));
  }];
  let assemblyFormat = "attr-dict";
}
```
which in theory should just be an LDS fence but I think there are standing compiler issues that make it not that

https://github.com/llvm/llvm-project/pull/110527