[Mlir-commits] [mlir] [mlir][gpu] Add address space modifier to Barrier (PR #110527)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Sep 30 09:21:25 PDT 2024


================
@@ -1371,11 +1372,25 @@ def GPU_BarrierOp : GPU_Op<"barrier"> {
     accessing the same memory can be avoided by synchronizing work items
     in-between these accesses.
 
+    The address space of visible memory accesses can be modified by adding a
+    list of address spaces required to be visible. By default all address spaces
+    are included.
----------------
FMarno wrote:

I'm not trying to say that the memory is visible, but that the memory accesses are visible. I think it makes sense when paired with the previous paragraph
> and all memory accesses made by these work items prior to the op are
    visible to all work items in the workgroup.

I think what @krzysz00 is saying matches.

I'm open to suggestions on how to make it more clear.

https://github.com/llvm/llvm-project/pull/110527


More information about the Mlir-commits mailing list