[Mlir-commits] [mlir] [mlir][tensor] Apply `InsertSliceOfTransferWriteOpFolder` only when `transfer_write` overwrites all elements of `insert_slice` (PR #108803)

[Benjamin Maxwell]

================
@@ -154,6 +167,17 @@ LogicalResult InsertSliceOfTransferWriteOpFolder::matchAndRewrite(
   return success();
 }
 
+bool InsertSliceOfTransferWriteOpFolder::doesTransferWriteCoverInsertSlice(
+    vector::TransferWriteOp writeOp) {
+  if (writeOp.getShapedType().hasStaticShape())
+    return llvm::equal(writeOp.getVectorType().getShape(),
+                       writeOp.getShapedType().getShape());
+
+  // TODO: ValueBoundsConstraintSet for dynamic shapes.
----------------
MacDue wrote:

Can you make the TODO a complete sentence. E.g. `// TODO: Use ValueBoundsConstraintSet ...`

https://github.com/llvm/llvm-project/pull/108803