[Mlir-commits] [llvm] [mlir] Fix LLVM_ENABLE_ABI_BREAKING_CHECKS macro check: use #if instead of #ifdef (PR #110185)

[Han-Chung Wang]

hanhanW wrote:

The change breaks downstream IREE project: https://github.com/iree-org/iree/actions/runs/11074921339/job/30774781373

It is not captured in CI because LLVM isn't building with whatever combination of asserts enabled and NDEBUG. I'd like ask for a revert because other places are not updated and it does not look like a trivial fix to me. E.g.,

https://github.com/llvm/llvm-project/blob/cd5f5b769010da31210bc55bd5e337ec60b34665/llvm/include/llvm/Transforms/Scalar/LoopPassManager.h#L298 is not updated.

There are other issues too. E.g.,

https://github.com/llvm/llvm-project/blob/cd5f5b769010da31210bc55bd5e337ec60b34665/llvm/include/llvm/Support/GenericDomTreeConstruction.h#L643-L645

https://github.com/llvm/llvm-project/blob/cd5f5b769010da31210bc55bd5e337ec60b34665/llvm/include/llvm/Support/GenericDomTreeConstruction.h#L818-L820

The variable is declared if one define is set, and it uses the variable if a different define is set.

Can we revert the change?

https://github.com/llvm/llvm-project/pull/110185