[Mlir-commits] [mlir] [mlir][spirv] Add gpu printf op lowering to spirv.CL.printf op (PR #78510)
Jakub Kuderski
llvmlistbot at llvm.org
Fri Sep 27 06:29:10 PDT 2024
================
@@ -597,6 +606,124 @@ class GPUSubgroupReduceConversion final
}
};
+/// Formulate unique variable/constant name after
+/// searching in the module for existing variable/constant names.
+/// This is to avoid name collision with existing variables.
+/// Example: printfMsg0, printfMsg1, printfMsg2, ...
----------------
kuhar wrote:
use `//` for comments since this is an internal function
```suggestion
// Formulate a unique variable/constant name after
// searching in the module for existing variable/constant names.
// This is to avoid name collision with existing variables.
// Example: printfMsg0, printfMsg1, printfMsg2, ...
```
https://github.com/llvm/llvm-project/pull/78510
More information about the Mlir-commits
mailing list