[Mlir-commits] [mlir] [mlir][func] Fix multiple bugs in `DuplicateFunctionElimination` (PR #109571)

[Longsheng Mou]

CoTinker wrote:

I've noticed that `replaceAllSymbolUsesImpl` uses `collectSymbolScopes` to traverse the region and `addReplacement` to perform replacements. Perhaps using `SymbolTable::replaceAllSymbolUses` inside the loop isn't as costly as we think.
https://github.com/llvm/llvm-project/blob/8dd817b25ae8b666aef839d36ffe028c01d411b5/mlir/lib/IR/SymbolTable.cpp#L877-L891
I'm not familiar with this, could you please take a look at it. @River707 

https://github.com/llvm/llvm-project/pull/109571