[Mlir-commits] [mlir] [MLIR] Add MLIRConversionPassIncGen to cmake deps for FrozenRewritePatternSet (PR #110054)

Mike Urbach llvmlistbot at llvm.org
Wed Sep 25 16:55:01 PDT 2024


https://github.com/mikeurbach approved this pull request.

I'm not super familiar with _why_ this library needs this dependency, but I do see it includes this header which transitively includes the generated mlir/Conversion/Passes.h.inc: https://github.com/llvm/llvm-project/blob/13809b3d95924d691db53e62182d8ad46b0e08ec/mlir/lib/Rewrite/FrozenRewritePatternSet.cpp#L20

So, given the current state, makes sense to me to add the explicit dependency. This seems to have been this way for years... I have no idea why CIRCT Python wheel CI/CD always seems to find these issues.

https://github.com/llvm/llvm-project/pull/110054


More information about the Mlir-commits mailing list