[Mlir-commits] [llvm] [mlir] [NFC] Add explicit #include abi-breaking.h where its macros are used. (PR #109453)

[Mehdi Amini]

joker-eph wrote:

> My expectation is that these changes would avoid a correct header removal from causing a build break under -Wundef. Means folks can remove unused headers without the spooky-action-at-a-distance cleanup required.

If this is really the problem to be solved, then this is what the description should explain clearly, and we can argue about it :)


Right now it seems that you're arguing against the policy of " You must include all of the header files that you are using — you can include them either directly or indirectly through another header file" ; so I'd rather first see a PR that rewrite this to endorse the policy you want to see in place (probably with an RFC on Discourse).


https://github.com/llvm/llvm-project/pull/109453