[Mlir-commits] [llvm] [mlir] [NFC] Add explicit #include abi-breaking.h where its macros are used. (PR #109453)

[Mehdi Amini]

joker-eph wrote:

> This patch seems to be an "include what you use" fix, which generally fix fragility (as the description says - cases where if an unrelated header was removed, the build would fail because the file that included the unrelated header was depending on that header providing some other header that's used). Looks like -Wundef would only protect from using a macro that's truly undefined, yeah?

Do you believe that any change in MLIR is protecting us from anything not covered by Wunder? If so can you describe the possible failure here?


> I think I'm mostly following it - could you clarify what's confusing to you?


Everythig about clangd: the sentence starts with "for example" as if it is an important illustration from "removing other headers, who implicitly include abi-breaking.h, may have non-trivial side effects".

I don't quite see how "removing abi-breaking.h"  can have as "side-effect" the fact that "clangd may report even abi-breaking.h as "no used" "


https://github.com/llvm/llvm-project/pull/109453