[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

[Han-Chung Wang]

================
@@ -2948,10 +2948,15 @@ struct Conv1DGenerator
     if (!setOperKind(reduceOp))
       return;
     auto maybeKind = getCombinerOpKind(reduceOp);
-    if (!maybeKind || (*maybeKind != vector::CombiningKind::ADD &&
----------------
hanhanW wrote:

Yeah, I think this is like "precondition", so we need to check the value and bail out when it is not supported. After it (i.e., constructor), we know that this is valid, so we don't need the "std::optional" around the `reductionKind`. So having the check looks good to me.

https://github.com/llvm/llvm-project/pull/109480