[Mlir-commits] [mlir] [mlir][OpenMP] - MLIR to LLVMIR translation support for delayed privatization in `omp.target` ops. (PR #109668)
    Christian Ulmann 
    llvmlistbot at llvm.org
       
    Mon Sep 23 12:56:36 PDT 2024
    
    
  
================
@@ -1356,6 +1356,38 @@ class OmpParallelOpConversionManager {
   unsigned privateArgEndIdx;
 };
 
+namespace {
+omp::PrivateClauseOp findPrivatizer(Operation *from, SymbolRefAttr symbolName) {
----------------
Dinistro wrote:
Nit: MLIR prefers static functions over functions in anonymous namespaces. Also, please comment functions. 
https://github.com/llvm/llvm-project/pull/109668
    
    
More information about the Mlir-commits
mailing list