[Mlir-commits] [mlir] [mlir][linalg] Vectorization support for convolution of i1 type (PR #109480)

[Han-Chung Wang]

================
@@ -3627,6 +3635,7 @@ struct Conv1DGenerator
   int strideW, dilationW;
   Value lhsShaped, rhsShaped, resShaped;
   ShapedType lhsShapedType, rhsShapedType, resShapedType;
+  std::optional<vector::CombiningKind> maybeKind;
----------------
hanhanW wrote:

Oh I see, thanks. @banach-space's comment makes sense to me. I think we can remove the optional because it is a requirement for conv vectorization?

https://github.com/llvm/llvm-project/pull/109480