[Mlir-commits] [mlir] [mlir] Use {} instead of std::nullopt to initialize empty ArrayRef (PR #109527)

Ivan Butygin llvmlistbot at llvm.org
Mon Sep 23 05:40:53 PDT 2024


Hardcode84 wrote:

> While the change to a longer fully qualified name is unfortunate, I think there is another aspect in this migration away from `std::nullopt`, which is that we will use `std::nullopt` only to express the empty `std::optional`. That is friendlier to newcomers to the LLVM project, who would typically see `std::nullopt` only in the context of `std::optional`.

I do not want to block anyone, but I'm still not sure if sacrificing convenience for ideological purity is good tradeoff here.

https://github.com/llvm/llvm-project/pull/109527


More information about the Mlir-commits mailing list