[Mlir-commits] [mlir] [Linalg][Vectorization] Add support for linalg vectorization of a tensor.extract case (PR #107922)

Andrzej WarzyƄski llvmlistbot at llvm.org
Thu Sep 19 11:51:59 PDT 2024


================
@@ -890,11 +907,10 @@ static bool isContiguousLoadIdx(LinalgOp &linalgOp, Value &val,
   Operation *defOp = val.getDefiningOp();
   assert(defOp && "This is neither a block argument nor an operation result");
 
-  // Given the assumption on the loop ranges above, only the trailing loop
-  // index is not constant.
-  auto trailingLoopDim = linalgOp.getStaticLoopRanges().size() - 1;
+  auto nonUnitLoopDim = getNonUnitLoopDim(linalgOp);
----------------
banach-space wrote:

[nit] It's worth adding a comment that given the assumption above (encoded in `assert`), we expect only 1 non-unit loop dim.

https://github.com/llvm/llvm-project/pull/107922


More information about the Mlir-commits mailing list