[Mlir-commits] [mlir] [MLIR][AMDGPU] Add OCP FP8 support for new hardware (PR #106160)

[Jakub Kuderski]

================
@@ -454,6 +454,20 @@ static void wmmaPushOutputOperand(ConversionPatternRewriter &rewriter,
   }
 }
 
+/// Return true if `type` is the E5M2 variant of an 8-bit float that is
+/// supported by the `_bf8` instructions on the given `chipset`.
+static bool isNativeBf8(Chipset chipset, Type type) {
----------------
kuhar wrote:

>  "is this type the same as the chipset's native BF8 type?"
Thanks for the explanation, I see the difference now. Maybe something like this then `isSupportedByNativeBf8(Chipset, Type)`?

If you prefer the current name, could you add a comment that explains what the intention is (similar to how you explained it above)?

https://github.com/llvm/llvm-project/pull/106160