[Mlir-commits] [mlir] [mlir][AMDGPU] Add support for AMD f16 math library calls (PR #108809)

[Nirvedh Meshram]

https://github.com/nirvedhmeshram requested changes to this pull request.

Regarding the two f16 calls that you are adding where f32 calls are not present, I am fine with whichever choice makes sense for the hardware but the following needs to be updated accordingly,
https://github.com/llvm/llvm-project/blob/main/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp#L338
It controls if for a given type we will make a llvm op or the library call. Otherwise which one happens may vary based on which pattern gets applied first.

https://github.com/llvm/llvm-project/pull/108809