[Mlir-commits] [mlir] [mlir][LLVM] Add operand bundle support (PR #108933)

[Markus Böck]

================
@@ -551,7 +551,13 @@ def LLVM_InvokeOp : LLVM_Op<"invoke", [
                    Variadic<LLVM_Type>:$normalDestOperands,
                    Variadic<LLVM_Type>:$unwindDestOperands,
                    OptionalAttr<DenseI32ArrayAttr>:$branch_weights,
-                   DefaultValuedAttr<CConv, "CConv::C">:$CConv);
+                   DefaultValuedAttr<CConv, "CConv::C">:$CConv,
+                   VariadicOfVariadic<LLVM_Type,
+                                      "op_bundle_sizes">:$op_bundle_operands,
+                   DenseI32ArrayAttr:$op_bundle_sizes,
+                   OptionalProperty<
+                     ArrayProperty<StringProperty, "operand bundle tags">
+                   >:$op_bundle_tags);
----------------
zero9178 wrote:

```suggestion
                     ArrayProperty<StringProperty, "operand bundle tags">:$op_bundle_tags);
```
Not sure I understand why we need to wrap this in an optional. Is there a semantic difference between an empty array and the array being non-present? 


https://github.com/llvm/llvm-project/pull/108933