[Mlir-commits] [mlir] [mlir][mesh] Fix empty `split_axes` sharding annotation (PR #108236)

Boian Petkantchin llvmlistbot at llvm.org
Thu Sep 19 06:44:08 PDT 2024


https://github.com/sogartar approved this pull request.

This change is consistent with the [doc](https://github.com/llvm/llvm-project/blob/9886788a8a500a1b429a6db64397c849b112251c/mlir/include/mlir/Dialect/Mesh/IR/MeshOps.td#L216-L219).
I can see why it is annoying and error prone that every usage of the attribute must check first if there are any subarrays in the array, but requiring the existence of the single empty subarray looks like a quirk.

https://github.com/llvm/llvm-project/pull/108236


More information about the Mlir-commits mailing list