[Mlir-commits] [mlir] [mlir] [LLVM IR] Introduce VaArgOp (PR #109260)

[Markus Böck]

https://github.com/zero9178 commented:

Looks great, thank you so much (and welcome to MLIR :smile:)!

The only nit I have is whether you could also add a test for the import functionality from LLVM IR to the LLVM Dialect (e.g. here: https://github.com/llvm/llvm-project/blob/912e821ab3d415dc8421f53738ebabcc7f1dac2d/mlir/test/Target/LLVMIR/Import/basic.ll#L80).


https://github.com/llvm/llvm-project/pull/109260