[Mlir-commits] [mlir] [mlir][vector][nfc] Update vector load/store doc wrt unit strides. (PR #109267)
Andrzej Warzyński
llvmlistbot at llvm.org
Thu Sep 19 04:06:48 PDT 2024
================
@@ -1655,6 +1655,7 @@ def Vector_LoadOp : Vector_Op<"load"> {
strides. Only unit strides are allowed along the most minor memref
dimension. These constraints guarantee that elements read along the first
dimension of the slice are contiguous in memory.
+ Non-unit strides are allowed when doing 0-rank or 1-element vector load.
----------------
banach-space wrote:
[nit]
```suggestion
strides. When loading more than 1 element, only unit strides are allowed along the most minor memref
dimension. These constraints guarantee that elements read along the first
dimension of the slice are contiguous in memory.
```
Rather than adding a sentence at the end (and splitting one condition across multiple sentences), why not just refine the current wording? Hope I'm not splitting hairs here 😅
https://github.com/llvm/llvm-project/pull/109267
More information about the Mlir-commits
mailing list