[Mlir-commits] [mlir] [mlir] Add the ability to define dialect-specific location attrs. (PR #105584)

River Riddle llvmlistbot at llvm.org
Tue Sep 17 20:01:38 PDT 2024


================
@@ -187,5 +210,8 @@ ParseResult Parser::parseLocationInstance(LocationAttr &loc) {
     return success();
   }
 
+  if (getToken().getSpelling() == "dialect")
----------------
River707 wrote:

Do you need this at all? I'd suggest printing the attribute directly, that should always get picked up by the `if (getToken().is(Token::hash_identifier))` code path. That would also remove most of this parser/printer code.

https://github.com/llvm/llvm-project/pull/105584


More information about the Mlir-commits mailing list