[Mlir-commits] [mlir] [mlir][spirv] Add gpu printf op lowering to spirv.CL.printf op (PR #78510)

Dimple Prajapati llvmlistbot at llvm.org
Tue Sep 17 18:29:12 PDT 2024


drprajap wrote:

> Thanks for the contribution, look like a useful debugging feature to have! I left some comments.
> 
> I find it hard to follow the `matchAndRewrite` code -- could we brake it down a bit and introduce some helper functions?

Thank you @kuhar for your feedback and sorry for the delay in addressing them. 
I added more comments and tried to clarify the functionality, let me know if it makes it a bit more clear.

https://github.com/llvm/llvm-project/pull/78510


More information about the Mlir-commits mailing list