[Mlir-commits] [mlir] [MLIR][AMDGPU] Add OCP FP8 support for new hardware (PR #106160)

Jakub Kuderski llvmlistbot at llvm.org
Tue Sep 17 08:25:00 PDT 2024


================
@@ -47,6 +47,13 @@ struct Chipset {
   DEFINE_COMP_OPERATOR(>)
   DEFINE_COMP_OPERATOR(>=)
 #undef DEFINE_COMP_OPERATOR
+
+  bool isGfx940() const {
+    return majorVersion == 9 && minorVersion >= 4 && minorVersion < 5;
----------------
kuhar wrote:

The condition is weird, this should be just `minorVersion == 4`. Also, I'd call it something like `isGfx940Series`, since it's not a strict match.

https://github.com/llvm/llvm-project/pull/106160


More information about the Mlir-commits mailing list