[Mlir-commits] [mlir] [Bufferization] Avoid repeated hash lookups (NFC) (PR #108925)

Kazu Hirata llvmlistbot at llvm.org
Mon Sep 16 21:27:14 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/108925

None

>From 2a7a314bced1a6308bd32a238d4b2d8a4f53390c Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Mon, 16 Sep 2024 06:52:57 -0700
Subject: [PATCH] [Bufferization] Avoid repeated hash lookups (NFC)

---
 mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp b/mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp
index d69c194c55f7d3..829e954d53b259 100644
--- a/mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp
+++ b/mlir/lib/Dialect/Bufferization/Transforms/OneShotAnalysis.cpp
@@ -284,9 +284,8 @@ static bool isReachable(Block *from, Block *to, ArrayRef<Block *> except) {
       continue;
     if (next == to)
       return true;
-    if (visited.contains(next))
+    if (!visited.insert(next).second)
       continue;
-    visited.insert(next);
     for (Block *succ : next->getSuccessors())
       worklist.push_back(succ);
   }



More information about the Mlir-commits mailing list