[Mlir-commits] [mlir] [ROCDL] Pass `amd_code_object_version` when serializing ROCDL gpu module (PR #108874)

Fabian Mora llvmlistbot at llvm.org
Mon Sep 16 15:55:30 PDT 2024


================
@@ -71,14 +71,17 @@ class SerializeGPUModuleBase : public LLVM::ModuleToObject {
   virtual std::optional<SmallVector<std::unique_ptr<llvm::Module>>>
   loadBitcodeFiles(llvm::Module &module) override;
 
-  /// Adds `oclc` control variables to the LLVM module.
+  /// Determines required Device Libraries and adds `oclc` control variables to
+  /// the LLVM Module if needed. Also sets
+  /// `amdhsa_code_object_version` module flag
   void handleModulePreLink(llvm::Module &module) override;
 
   /// Removes unnecessary metadata from the loaded bitcode files.
   LogicalResult handleBitcodeFile(llvm::Module &module) override;
 
 protected:
-  /// Adds `oclc` control variables to the LLVM module.
+  /// Adds `oclc` control variables to the LLVM Module if needed and sets
+  /// `amdhsa_code_object_version` module flag
----------------
fabianmcg wrote:

```suggestion
  /// `amdhsa_code_object_version` module flag.
```

https://github.com/llvm/llvm-project/pull/108874


More information about the Mlir-commits mailing list