[Mlir-commits] [mlir] [mlir][tensor] Apply `InsertSliceOfTransferWriteOpFolder` only when `transfer_write` overwrites all elements of `insert_slice` (PR #108803)

Benjamin Maxwell llvmlistbot at llvm.org
Mon Sep 16 04:30:58 PDT 2024


MacDue wrote:

> I presume for dynamic sizes you meant to use `ValueBoundsConstraintSet`?

Yes, my idea where was you check the size of the vector dimensions >= the upper bound on the size of the dynamic tensor destination (if a upper bound can be resolved). 

> For static sizes we just check `dim[i]` (for each i in all dimensions) that it is equal for both source and destination?

Yep :+1: 

For a first patch maybe just fix the issue for static sizes and fail for dynamic sizes (where the transform may not be correct). 

https://github.com/llvm/llvm-project/pull/108803


More information about the Mlir-commits mailing list