[Mlir-commits] [mlir] [mlir][tosa] Convert group tosa::Conv2DOp to linalg conv (PR #108192)

[Eric Kunze]

================
@@ -106,6 +106,7 @@ def Tosa_Conv2DOp : Tosa_InferShapedTypeOp<"conv2d"> {
     Tosa_IntArrayAttr4:$pad,
     Tosa_IntArrayAttr2:$stride,
     Tosa_IntArrayAttr2:$dilation,
+    OptionalAttr<I64Attr>:$group,
----------------
eric-k256 wrote:

As @GeorgeARM pointed out, this doesn't match what is in the TOSA specification. The dialect should be a representation of the specification. 
We recently took a look at grouped convolution, and most of the use cases we saw could be handled by creating multiple TOSA Conv2d ops.

https://github.com/llvm/llvm-project/pull/108192