[Mlir-commits] [mlir] [mlir][tosa] Convert group tosa::Conv2DOp to linalg conv (PR #108192)

[Suraj Sudhir]

sjarus wrote:

Hi there, sorry for the delay and thanks for this contribution! As @GeorgeARM  mentioned, TOSA has a [specification](https://www.mlplatform.org/tosa/tosa_spec.html) that the dialect implements. This is because the spec is also used to design hardware and backend software stacks that depend on the existence of a stable IR construct. 

We'd be happy to help you/your organization contribute to the specification with this proposal and it'll then work its way into the dialect. However, this will take more time to add, than the time to make a dialect change that has no specification impact (e.g. update a verifier) 

Until then, to unblock you is it possible to address this as two separate things - the change to the dialect (with its spec relationship) and the TosaToLinalg pass. Is it an option to refactor the latter to pattern match multiple tosa.conv2d instances that constitute a grouped convolution ? 

https://github.com/llvm/llvm-project/pull/108192