[Mlir-commits] [mlir] [mlir][AMDGPU] Remove an old bf16 workaround (PR #108409)

Jakub Kuderski llvmlistbot at llvm.org
Thu Sep 12 12:00:45 PDT 2024


================
@@ -672,7 +672,10 @@ struct WMMAOpLowering : public ConvertOpToLLVMPattern<WMMAOp> {
                   ConversionPatternRewriter &rewriter) const override {
     Location loc = op.getLoc();
     auto outType =
-        cast<VectorType>(typeConverter->convertType(op.getDestD().getType()));
+        typeConverter->convertType<VectorType>(op.getDestD().getType());
+    if (!outType)
+      return rewriter.notifyMatchFailure(
+          op, "wmma output doesn't convert to a vector for no clear reason");
----------------
kuhar wrote:

or just
```suggestion
          op, "type conversion failed");
```
(this is what we do in spirv lowering)

https://github.com/llvm/llvm-project/pull/108409


More information about the Mlir-commits mailing list