[Mlir-commits] [mlir] [TableGen] Avoid repeated hash lookups (NFC) (PR #108321)

Kazu Hirata llvmlistbot at llvm.org
Wed Sep 11 20:00:44 PDT 2024


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/108321

None

>From 5256485f3905ff8bb62fcb8d7bbd9f2c704c0b50 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Wed, 11 Sep 2024 06:46:40 -0700
Subject: [PATCH] [TableGen] Avoid repeated hash lookups (NFC)

---
 mlir/lib/TableGen/CodeGenHelpers.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mlir/lib/TableGen/CodeGenHelpers.cpp b/mlir/lib/TableGen/CodeGenHelpers.cpp
index 314b20491460aa..7e7640303a1256 100644
--- a/mlir/lib/TableGen/CodeGenHelpers.cpp
+++ b/mlir/lib/TableGen/CodeGenHelpers.cpp
@@ -258,9 +258,9 @@ std::string StaticVerifierFunctionEmitter::getUniqueName(StringRef kind,
 void StaticVerifierFunctionEmitter::collectConstraint(ConstraintMap &map,
                                                       StringRef kind,
                                                       Constraint constraint) {
-  auto *it = map.find(constraint);
-  if (it == map.end())
-    map.insert({constraint, getUniqueName(kind, map.size())});
+  auto [it, inserted] = map.try_emplace(constraint);
+  if (inserted)
+    it->second = getUniqueName(kind, map.size());
 }
 
 void StaticVerifierFunctionEmitter::collectOpConstraints(



More information about the Mlir-commits mailing list