[Mlir-commits] [mlir] b35bb7b - [mlir] Fix 'StringSet' may not intend to support class template argument deduction (NFC)

Jie Fu llvmlistbot at llvm.org
Wed Sep 11 04:47:38 PDT 2024


Author: Jie Fu
Date: 2024-09-11T19:46:26+08:00
New Revision: b35bb7b797e81e1d972c8e6d60e20e39c1917b99

URL: https://github.com/llvm/llvm-project/commit/b35bb7b797e81e1d972c8e6d60e20e39c1917b99
DIFF: https://github.com/llvm/llvm-project/commit/b35bb7b797e81e1d972c8e6d60e20e39c1917b99.diff

LOG: [mlir] Fix 'StringSet' may not intend to support class template argument deduction (NFC)

/llvm-project/mlir/tools/mlir-tblgen/OmpOpGen.cpp:202:3:
error: 'StringSet' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
  llvm::StringSet superClasses;
  ^
/llvm-project/llvm/include/llvm/ADT/StringSet.h:23:7: note: add a deduction guide to suppress this warning
class StringSet : public StringMap<std::nullopt_t, AllocatorTy> {
      ^

Added: 
    

Modified: 
    mlir/tools/mlir-tblgen/OmpOpGen.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/tools/mlir-tblgen/OmpOpGen.cpp b/mlir/tools/mlir-tblgen/OmpOpGen.cpp
index f546e1b1b6691c..c9d25a5dee5cd7 100644
--- a/mlir/tools/mlir-tblgen/OmpOpGen.cpp
+++ b/mlir/tools/mlir-tblgen/OmpOpGen.cpp
@@ -199,7 +199,7 @@ static StringRef translateArgumentType(ArrayRef<SMLoc> loc, StringInit *name,
                                        Init *init, int &nest, int &rank) {
   Record *def = cast<DefInit>(init)->getDef();
 
-  llvm::StringSet superClasses;
+  llvm::StringSet<> superClasses;
   for (auto [sc, _] : def->getSuperClasses())
     superClasses.insert(sc->getNameInitAsString());
 


        


More information about the Mlir-commits mailing list