[Mlir-commits] [mlir] [mlir][vector] Replace cast_or_null with dyn_cast_or_null (PR #108048)

Diego Caballero llvmlistbot at llvm.org
Tue Sep 10 15:30:47 PDT 2024


https://github.com/dcaballe requested changes to this pull request.

Hmm... this is not correct. If there is a maskable op it should implement the maskable op interface, otherwise it's a bug.

For this particular test case, we shouldn't be masking a `vector.bitcast` because speculatively executing a bitcast don't have any side effects.

https://github.com/llvm/llvm-project/pull/108048


More information about the Mlir-commits mailing list