[Mlir-commits] [mlir] [mlir] [dataflow] Refactoring the definition of program points in dat… (PR #105656)

[Mehdi Amini]

joker-eph wrote:

> We definitely need a way to notify all downstream stakeholders about the necessary infrastructure changes. I have another related commit in development, and I'm curious about what measures we can take to ensure it doesn't break compatibility with downstream repos (for example, perhaps creating a new dataflow directory for this commit?). And I'm also wondering at what point it would be safe to break compatibility.Any help is appreciated.

You did nothing wrong, it's fine. We break APIs all the time.
It's also hard to evolve components without breaking any use-cases, usually downstream find a way to update but sometimes we miss one use-case that can't be implemented anymore. In such case we just revert and work it out collaboratively (downstream are expected to actively contribute to the solution) to be able to re-land.

Downstream should implement better upstream test to model their use-cases if they want these to be better supported/maintained, otherwise they deal with occasional breakages.

https://github.com/llvm/llvm-project/pull/105656