[Mlir-commits] [mlir] [mlir] [dataflow] Refactoring the definition of program points in dat… (PR #105656)

Marius Brehler llvmlistbot at llvm.org
Tue Sep 10 08:09:55 PDT 2024


marbre wrote:

> If necessary, I'm glad to revert this code. Should I revert this now?

It seems @rsuderman found a way that work for torch-mlir, so let's wait for his feedback.

> We definitely need a way to notify all downstream stakeholders about the necessary infrastructure changes. I have another related commit in development, and I'm curious about what measures we can take to ensure it doesn't break compatibility with downstream repos (for example, perhaps creating a new dataflow directory for this commit?). And I'm also wondering at what point it would be safe to break compatibility.Any help is appreciated.

Posting an RFC and discussion with upstream could be an option. If the changes break compatibility, it seems common to send out a PSA (https://discourse.llvm.org/search?q=MLIR%20PSA) to inform users prior to merging.

https://github.com/llvm/llvm-project/pull/105656


More information about the Mlir-commits mailing list