[Mlir-commits] [mlir] [MLIR] Make `resolveCallable` customizable in `CallOpInterface` (PR #100361)

Tue Sep 10 01:21:44 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-latest-gcc` running on `linaro-flang-aarch64-latest-gcc` while building `mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/3275

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
      |                ^~~~~~~
289.607 [3321/33/3833] Building CXX object tools/mlir/lib/Dialect/SparseTensor/Transforms/CMakeFiles/obj.MLIRSparseTensorTransforms.dir/SparseTensorRewriting.cpp.o
290.080 [3321/32/3834] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaInferShapes.cpp.o
290.121 [3319/33/3835] Creating library symlink lib/libMLIRTransformDialectUtils.so
290.146 [3317/34/3836] Creating library symlink lib/libMLIRFunctionInterfaces.so
290.161 [3317/33/3837] Building CXX object tools/mlir/lib/Dialect/Transform/Transforms/CMakeFiles/obj.MLIRTransformDialectTransforms.dir/InferEffects.cpp.o
290.163 [3316/33/3838] Creating library symlink lib/libMLIRUBDialect.so
290.299 [3316/32/3839] Creating library symlink lib/libMLIRCallInterfaces.so
290.509 [3311/36/3840] Building CXX object tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/FoldTensorSubsetOps.cpp.o
290.671 [3310/36/3841] Linking CXX shared library lib/libMLIRAsyncDialect.so.20.0git
FAILED: lib/libMLIRAsyncDialect.so.20.0git 
: && /usr/local/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libMLIRAsyncDialect.so.20.0git -o lib/libMLIRAsyncDialect.so.20.0git tools/mlir/lib/Dialect/Async/IR/CMakeFiles/obj.MLIRAsyncDialect.dir/Async.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib:"  lib/libMLIRControlFlowInterfaces.so.20.0git  lib/libMLIRFunctionInterfaces.so.20.0git  lib/libMLIRDialect.so.20.0git  lib/libMLIRInferTypeOpInterface.so.20.0git  lib/libMLIRIR.so.20.0git  lib/libMLIRSupport.so.20.0git  lib/libLLVMSupport.so.20.0git  -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib && :
/usr/bin/ld: tools/mlir/lib/Dialect/Async/IR/CMakeFiles/obj.MLIRAsyncDialect.dir/Async.cpp.o: in function `mlir::detail::CallOpInterfaceInterfaceTraits::Model<mlir::async::CallOp>::resolveCallable(mlir::detail::CallOpInterfaceInterfaceTraits::Concept const*, mlir::Operation*)':
Async.cpp:(.text._ZN4mlir6detail30CallOpInterfaceInterfaceTraits5ModelINS_5async6CallOpEE15resolveCallableEPKNS1_7ConceptEPNS_9OperationE[_ZN4mlir6detail30CallOpInterfaceInterfaceTraits5ModelINS_5async6CallOpEE15resolveCallableEPKNS1_7ConceptEPNS_9OperationE]+0xf4): undefined reference to `mlir::call_interface_impl::resolveCallable(mlir::CallOpInterface, mlir::SymbolTableCollection*)'
/usr/bin/ld: tools/mlir/lib/Dialect/Async/IR/CMakeFiles/obj.MLIRAsyncDialect.dir/Async.cpp.o: in function `mlir::detail::CallOpInterfaceInterfaceTraits::Model<mlir::async::CallOp>::resolveCallableInTable(mlir::detail::CallOpInterfaceInterfaceTraits::Concept const*, mlir::Operation*, mlir::SymbolTableCollection*)':
Async.cpp:(.text._ZN4mlir6detail30CallOpInterfaceInterfaceTraits5ModelINS_5async6CallOpEE22resolveCallableInTableEPKNS1_7ConceptEPNS_9OperationEPNS_21SymbolTableCollectionE[_ZN4mlir6detail30CallOpInterfaceInterfaceTraits5ModelINS_5async6CallOpEE22resolveCallableInTableEPKNS1_7ConceptEPNS_9OperationEPNS_21SymbolTableCollectionE]+0xf8): undefined reference to `mlir::call_interface_impl::resolveCallable(mlir::CallOpInterface, mlir::SymbolTableCollection*)'
collect2: error: ld returned 1 exit status
290.764 [3310/35/3842] Linking CXX shared library lib/libMLIRFuncDialect.so.20.0git
290.836 [3310/34/3843] Building CXX object tools/mlir/lib/Pass/CMakeFiles/obj.MLIRPass.dir/IRPrinting.cpp.o
290.914 [3310/33/3844] Linking CXX shared library lib/libMLIRArithDialect.so.20.0git
290.919 [3310/32/3845] Linking CXX shared library lib/libMLIRLoopLikeInterface.so.20.0git
290.927 [3310/31/3846] Linking CXX shared library lib/libMLIRPDLInterpDialect.so.20.0git
290.943 [3310/30/3847] Linking CXX shared library lib/libMLIREmitCDialect.so.20.0git
291.658 [3310/29/3848] Building CXX object tools/mlir/lib/Dialect/SparseTensor/Transforms/CMakeFiles/obj.MLIRSparseTensorTransforms.dir/Utils/LoopEmitter.cpp.o
291.920 [3310/28/3849] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorBitCast.cpp.o
292.057 [3310/27/3850] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaMakeBroadcastable.cpp.o
292.259 [3310/26/3851] Building CXX object tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o
293.928 [3310/25/3852] Building CXX object tools/mlir/lib/Dialect/SPIRV/Transforms/CMakeFiles/obj.MLIRSPIRVTransforms.dir/LowerABIAttributesPass.cpp.o
In file included from ../llvm-project/mlir/include/mlir/Dialect/Vector/IR/VectorOps.h:25,
                 from ../llvm-project/mlir/include/mlir/Dialect/Vector/Transforms/VectorRewritePatterns.h:15,
                 from ../llvm-project/mlir/include/mlir/Dialect/SPIRV/Transforms/SPIRVConversion.h:20,
                 from ../llvm-project/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp:21:
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h: In instantiation of ‘class mlir::OpConversionPattern<mlir::spirv::FuncOp>’:
../llvm-project/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp:205:45:   required from here
../llvm-project/mlir/include/mlir/IR/PatternMatch.h:255:16: warning: ‘virtual void mlir::RewritePattern::rewrite(mlir::Operation*, mlir::PatternRewriter&) const’ was hidden [-Woverloaded-virtual=]
  255 |   virtual void rewrite(Operation *op, PatternRewriter &rewriter) const;
      |                ^~~~~~~
In file included from ../llvm-project/mlir/include/mlir/Dialect/SPIRV/Transforms/SPIRVConversion.h:21:
../llvm-project/mlir/include/mlir/Transforms/DialectConversion.h:552:16: note:   by ‘mlir::OpConversionPattern<mlir::spirv::FuncOp>::rewrite’
  552 |   virtual void rewrite(SourceOp op, OpAdaptor adaptor,
      |                ^~~~~~~
294.181 [3310/24/3853] Building CXX object tools/mlir/lib/Dialect/Transform/Transforms/CMakeFiles/obj.MLIRTransformDialectTransforms.dir/TransformInterpreterUtils.cpp.o
295.155 [3310/23/3854] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorBroadcast.cpp.o
295.620 [3310/22/3855] Building CXX object tools/mlir/lib/Dialect/XeGPU/Transforms/CMakeFiles/obj.MLIRXeGPUTransforms.dir/XeGPUFoldAliasOps.cpp.o
295.848 [3310/21/3856] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorInterleave.cpp.o
297.020 [3310/20/3857] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaValidation.cpp.o
297.816 [3310/19/3858] Building CXX object tools/mlir/lib/Dialect/Vector/Transforms/CMakeFiles/obj.MLIRVectorTransforms.dir/LowerVectorGather.cpp.o
298.343 [3310/18/3859] Building CXX object tools/mlir/lib/Dialect/SPIRV/Transforms/CMakeFiles/obj.MLIRSPIRVConversion.dir/SPIRVConversion.cpp.o
In file included from ../llvm-project/mlir/include/mlir/Dialect/Vector/IR/VectorOps.h:25,

```

</details>

https://github.com/llvm/llvm-project/pull/100361