[Mlir-commits] [mlir] [TOSA] tosa.negate operator lowering update (PR #107924)
Georgios Pinitas
llvmlistbot at llvm.org
Mon Sep 9 15:13:52 PDT 2024
https://github.com/GeorgeARM approved this pull request.
LGTM. Have a couple of questions:
- The TOSA spec highlights that `input_zp` and `output_zp` must be zero for non-int8 types. I presume if that is the case then some of the code can be simplified when it comes to integer handling?
- Is there a verifier for the negate op that checks the above?
https://github.com/llvm/llvm-project/pull/107924
More information about the Mlir-commits
mailing list