[Mlir-commits] [mlir] [MLIR][Python] Python binding support for IntegerSet attribute (PR #107640)

Amy Wang llvmlistbot at llvm.org
Mon Sep 9 13:25:35 PDT 2024


================
@@ -10,6 +10,7 @@
 #include "mlir-c/Support.h"
 #include "mlir/CAPI/AffineMap.h"
 #include "mlir/CAPI/IR.h"
+#include "mlir/CAPI/IntegerSet.h"
----------------
kaitingwang wrote:

Thank you for the review!   The reason this is needed is because CAPI/IntegerSet.h includes the following:

```c++
 18 #include "mlir-c/IntegerSet.h"                                                                                          
 19 #include "mlir/CAPI/Wrap.h"                                                                                             
 20 #include "mlir/IR/IntegerSet.h"         
```

Including it for the sake of picking up mlir-c/IntegerSet.h is not needed as you pointed out since this is included by BuiltinAttributes.h.  However, we also need the mlir/IR/IntegerSet.h.  Following the AffineMap.h convention of earlier work, I include CAPI/IntegerSet.h.

https://github.com/llvm/llvm-project/pull/107640


More information about the Mlir-commits mailing list