[Mlir-commits] [lld] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used, last part. (PR #107615)

[Mehdi Amini]

joker-eph wrote:

> No. Just because clangd should check a particular compilation of each module, it uses a set of defines (the most convenient way I guess is to use compile_commands.json) and we have no guarantee we checked all of the combinations of configurations (including host, targets, libraries etc). 

Right, it'll use whatever you have in your local build environment I believe (even simple things as NDEBUG depends if you have a release or assert build), I don't think it can do differently?

> The only way to be sure that all defines have appropriate definitions is to explicitly include corresponding configuration headers.

I don't quite understand how adding this include changes **anything**? (I assume they are already transitively included right?)

https://github.com/llvm/llvm-project/pull/107615