[Mlir-commits] [mlir] [mlir] Rectify mishandling in `InsertOpConstantFolder` causing crash with assertion when using `mlir-opt --canonicalize` (PR #88314)

[Mehdi Amini]

================
@@ -0,0 +1,10 @@
+// RUN: mlir-opt -split-input-file -verify-diagnostics %s -canonicalize
+
+llvm.func @malloc(i64) -> !llvm.ptr
+func.func @func2(%arg0: index, %arg1: memref<13x13xi64>, %arg2: index) {
+  %cst_7 = arith.constant dense<1526248407> : vector<1xi64>
+  %1 = llvm.mlir.constant(1 : index) : i64
----------------
joker-eph wrote:

The fact that we allow the `llvm.mlir.constant` to materialize an integer with another type is a bug I believe (unfortunately this creeped up and is quite involved to fix now, I tried... :( )


https://github.com/llvm/llvm-project/pull/88314