[Mlir-commits] [lld] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used, last part. (PR #107615)

[Mehdi Amini]

joker-eph wrote:

> Without these explicit includes, removing other headers, who implicitly include llvm-config.h, may have non-trivial side effects. 

I'm not opposed to this change, but how does it differ from any other headers? I didn't quite get what would be special about llvm-config.h here?

> For example, clangd may report even llvm-config.h as "no used" in case it defines a macro, that is explicitly used with #ifdef. It is actually amplified with different build configs which use different set of macros.

You start this sentence with "For example", but I can't follow how what you're describing relates to the first sentence?

https://github.com/llvm/llvm-project/pull/107615