[Mlir-commits] [mlir] e40c5b4 - [lsp] Fix format string in Reply (#107480)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Sep 6 02:42:05 PDT 2024


Author: Lily Brown
Date: 2024-09-06T10:42:02+01:00
New Revision: e40c5b42fe8f489ea4bac4694ef58f09bd95263b

URL: https://github.com/llvm/llvm-project/commit/e40c5b42fe8f489ea4bac4694ef58f09bd95263b
DIFF: https://github.com/llvm/llvm-project/commit/e40c5b42fe8f489ea4bac4694ef58f09bd95263b.diff

LOG: [lsp] Fix format string in Reply (#107480)

PR #105745 requires that `formatv` calls have the correct number of
arguments. This call to `Logger::info` was incorrect.

Added: 
    

Modified: 
    mlir/lib/Tools/lsp-server-support/Transport.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Tools/lsp-server-support/Transport.cpp b/mlir/lib/Tools/lsp-server-support/Transport.cpp
index ca7ffdf78d3a1b..ad8308f69aead8 100644
--- a/mlir/lib/Tools/lsp-server-support/Transport.cpp
+++ b/mlir/lib/Tools/lsp-server-support/Transport.cpp
@@ -75,7 +75,7 @@ void Reply::operator()(llvm::Expected<llvm::json::Value> reply) {
     transport->reply(std::move(id), std::move(reply));
   } else {
     llvm::Error error = reply.takeError();
-    Logger::info("--> reply:{0}({1})", method, id, error);
+    Logger::info("--> reply:{0}({1}): {2}", method, id, error);
     transport->reply(std::move(id), std::move(error));
   }
 }


        


More information about the Mlir-commits mailing list